There is no point keeping the rawCall method private. On the other hand, the rawCall method being protected makes it easier to extend \Ovh\Api class.
Use case : I extend \Ovh\Api class and want to override get, post, put and delete methods to manipulate $content param before making a request. I cannot do this now because i cannot call private rawCall method from a child class. I can provide a quick explanation snippet if needed.
As I already mentioned in the #35 issue, I think it's more suitable to use a PHP build tool instead of a JS one. I don't tell that Grunt is not a powerful tool but it's a complicated installation process to be able to run tests.
Phing is required as a composer package and can be run directly after the composer install.
Examples:
```
vendor/bin/phing
vendor/bin/phing test
vendor/bin/phing clean
vendor/bin/phing phplint
vendor/bin/phing phpcs
vendor/bin/phing phpunit
vendor/bin/phing phpunit -Donly.units=true #The travis test process
```
The only difference here is the watch process. Phing doesn't have that kind of feature. It can be emulated with different tasks but require a lot more work. I think that PR is the first step, maybe we can go further if necessary.
Signed-off-by: Stéphane HULARD <s.hulard@chstudio.fr>
Remove the `$this->http_client->get()` call used in the `calculateTimeDelta` method.
This call is too coupled to the HttpClient, using the same method for all the calls is always better.
Signed-off-by: Stéphane HULARD <s.hulard@chstudio.fr>
This new method allow to perform a `rawCall` call and retrieve the full response instance.
It'll help to manipulate response more easily.
Signed-off-by: Stéphane HULARD <s.hulard@chstudio.fr>
