From 57ba00310db69b171af38db7f503eb5f6abd1b3c Mon Sep 17 00:00:00 2001
From: Romain Beuque <romain.beuque@corp.ovh.com>
Date: Thu, 21 Jan 2016 18:22:06 +0000
Subject: [PATCH] Added tests for #27 + fix empty comparaison

Signed-off-by: Romain Beuque <romain.beuque@corp.ovh.com>
---
 src/Api.php       |  2 +-
 tests/ApiTest.php | 87 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 88 insertions(+), 1 deletion(-)

diff --git a/src/Api.php b/src/Api.php
index e521cb5..f34040b 100644
--- a/src/Api.php
+++ b/src/Api.php
@@ -226,7 +226,7 @@ class Api
             $query_string = $request->getUri()->getQuery();
 
             $query = array();
-            if ($query_string != '') {
+            if (!empty($query_string)) {
                 $queries = explode('&', $query_string);
                 foreach($queries as $element) {
                     $key_value_query = explode('=', $element, 2);
diff --git a/tests/ApiTest.php b/tests/ApiTest.php
index a1375bc..f9db6d9 100644
--- a/tests/ApiTest.php
+++ b/tests/ApiTest.php
@@ -30,6 +30,7 @@ namespace Ovh\tests;
 use GuzzleHttp\Client;
 use GuzzleHttp\Middleware;
 use GuzzleHttp\Psr7\Response;
+use GuzzleHttp\Psr7\Request;
 use Ovh\Api;
 
 /**
@@ -280,4 +281,90 @@ class ApiTest extends \PHPUnit_Framework_TestCase
         $api = new Api($this->application_key, $this->application_secret, $this->endpoint, $this->consumer_key, $this->client);
         $this->assertEquals($this->consumer_key, $api->getConsumerKey());
     }
+
+
+    /**
+     * Test GET query args
+     */
+    public function testGetQueryArgs()
+    {
+        $handlerStack = $this->client->getConfig('handler');
+        $handlerStack->push(Middleware::mapRequest(function (Request $request) {
+            if($request->getUri()->getPath() == "/1.0/auth/time") {
+                return $request;
+            }
+
+            $query_string = $request->getUri()->getQuery();
+            $this->assertEquals($query_string, 'applicationId=49&status=pendingValidation');
+
+            $request = $request->withUri($request->getUri()
+                ->withHost('httpbin.org')
+                ->withPath('/')
+                ->withQuery(''));
+            return $request;
+        }));
+        //$handlerStack->push(Middleware::mapResponse(function (Response $response) {
+        //    return $response;
+        //}));
+
+        $api = new Api($this->application_key, $this->application_secret, $this->endpoint, $this->consumer_key, $this->client);
+        $api->get('/me/api/credential?applicationId=49', ['status' => 'pendingValidation']);
+    }
+
+    /**
+     * Test GET overlapping query args
+     */
+    public function testGetOverlappingQueryArgs()
+    {
+        $handlerStack = $this->client->getConfig('handler');
+        $handlerStack->push(Middleware::mapRequest(function (Request $request) {
+            if($request->getUri()->getPath() == "/1.0/auth/time") {
+                return $request;
+            }
+
+            $query_string = $request->getUri()->getQuery();
+            $this->assertEquals($query_string, 'applicationId=49&status=expired&test=success');
+
+            $request = $request->withUri($request->getUri()
+                ->withHost('httpbin.org')
+                ->withPath('/')
+                ->withQuery(''));
+            return $request;
+        }));
+        //$handlerStack->push(Middleware::mapResponse(function (Response $response) {
+        //    return $response;
+        //}));
+
+        $api = new Api($this->application_key, $this->application_secret, $this->endpoint, $this->consumer_key, $this->client);
+        $api->get('/me/api/credential?applicationId=49&status=pendingValidation', ['status' => 'expired', 'test' => "success"]);
+    }
+
+    /**
+     * Test GET boolean query args
+     */
+    public function testGetBooleanQueryArgs()
+    {
+        $handlerStack = $this->client->getConfig('handler');
+        $handlerStack->push(Middleware::mapRequest(function (Request $request) {
+            if($request->getUri()->getPath() == "/1.0/auth/time") {
+                return $request;
+            }
+
+            $query_string = $request->getUri()->getQuery();
+            $this->assertEquals($query_string, 'dryRun=true&notDryRun=false');
+
+            $request = $request->withUri($request->getUri()
+                ->withHost('httpbin.org')
+                ->withPath('/')
+                ->withQuery(''));
+            return $request;
+        }));
+        //$handlerStack->push(Middleware::mapResponse(function (Response $response) {
+        //    return $response;
+        //}));
+
+        $api = new Api($this->application_key, $this->application_secret, $this->endpoint, $this->consumer_key, $this->client);
+        $api->get('/me/api/credential', ['dryRun' => true, 'noDryRun' => false]);
+    }
+
 }