mj/php-ovh
1
0
Fork 0
mirror of https://github.com/ovh/php-ovh.git synced 2023-11-05 03:20:26 +01:00
Code Issues Releases Wiki Activity

Make rawCall method protected instead of private

Browse Source 
There is no point keeping the rawCall method private. On the other hand, the rawCall method being protected makes it easier to extend \Ovh\Api class.

Use case : I extend \Ovh\Api class and want to override get, post, put and delete methods to manipulate $content param before making a request. I cannot do this now because i cannot call private rawCall method from a child class. I can provide a quick explanation snippet if needed.
This commit is contained in:
hedii 2017-10-04 14:20:15 +02:00 committed by GitHub
parent 473feb2497
commit 1b19b16def
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Api.php
View File

@ -223,7 +223,7 @@ class Api
* @return array * @return array
* @throws \GuzzleHttp\Exception\ClientException if http request is an error * @throws \GuzzleHttp\Exception\ClientException if http request is an error
*/ */
private function rawCall($method, $path, $content = null, $is_authenticated = true, $headers = null) protected function rawCall($method, $path, $content = null, $is_authenticated = true, $headers = null)
{ {
$url = $this->endpoint . $path; $url = $this->endpoint . $path;
$request = new Request($method, $url); $request = new Request($method, $url);